Add instructions to README, and update link on Get Started page #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaesy
commented
Jul 21, 2024
| ## 👀 Want to learn more? | ||
|
|
||
| Check out [our documentation](https://docs.astro.build) or jump into our [Discord server](https://astro.build/chat). | ||
|
|
||
| ## Credit | ||
|
|
||
| This theme is based off of the lovely [Bear Blog](https://github.com/HermanMartinus/bearblog/). | ||
| This theme is based off of the lovely [Bear Blog](https://github.com/HermanMartinus/bearblog/). |
There was a problem hiding this comment.
No changes, Git marks as a change - not relevant.
taoeffect
requested changes
Jul 21, 2024
| @@ -35,10 +35,21 @@ All commands are run from the root of the project, from a terminal: | |||
| | `npm run astro ...` | Run CLI commands like `astro add`, `astro check` | | |||
| | `npm run astro --help` | Get help using the Astro CLI | | |||
|
|
|||
| ## Instructions on how to run your own server | |||
| The archive file contains a dist/ folder that needs to be placed into a copy of this cloned repo. Then you can serve it using grunt serve. On a production site, you should to use these environment variables: | |||
There was a problem hiding this comment.
Ahh, I see... what happened, sorry for not being clear in the issue - but this section should be added to the README in the group-income repo, not the groupincome.org repo. Can you send in a PR there?
For this PR we just need the change below to link to the group-income repo.
(Also, can you add an empty line after the heading too?)
| @@ -21,7 +21,7 @@ import Servers from '../components/Servers.vue'; | |||
| <Servers /> | |||
| <p class="c-container-para"> | |||
| Don’t see a server you like? | |||
| <a href="https://github.com/okTurtles/group-income" class="link server-link" target="_blank"> | |||
| <a href="https://github.com/okTurtles/groupincome.org#-instructions-on-how-to-run-your-own-server" class="link server-link" target="_blank"> | |||
There was a problem hiding this comment.
Please update this to point to the group-income repo's README, and double-check that the hash is correct as I'd be surprised if it started with a -...
|
Stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions in README with an anchor (#).
Added redirect from Get started page to the anchor in README in the original repo.
Issue #122