Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #72: UnboundLocalError user variable fix for github and gitlab #73

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

onuralpszr
Copy link
Contributor

@onuralpszr onuralpszr commented Oct 3, 2024

Hello 👋 I am contributor from roboflow/supervision project and Maintainer @LinasKo notice that we have issue in fetching avatars and I made fix for #72 for both gitlab and github based on api docs.

Test case (we should be able to build docs without error)

export GITHUB_TOKEN_ENV=github_pat_xxxxxx
rm -rf .cache/plugin/git-committers/
pip install git+http://github.com/onuralpszr/mkdocs-git-committers-plugin-2@fix/issue72
mkdocs build

Small wish: It would be nice to have hotfix pypi release so we can also have cleanly update our side instead of downgrade package as well.

Thank you.

cc @ojacques
For test: cc @LinasKo

@onuralpszr
Copy link
Contributor Author

@GriceTurrble good catch thank you very much, I applied the changes

@onuralpszr
Copy link
Contributor Author

Friendly friday ping @ojacques for quick review/merge and hopefully release please :)

@ojacques
Copy link
Owner

ojacques commented Oct 4, 2024

Good people... You rock! Thanks. Merging and releasing.

@ojacques ojacques changed the title fix: UnboundLocalError user variable fix for github and gitlab fix #72: UnboundLocalError user variable fix for github and gitlab Oct 4, 2024
@ojacques ojacques merged commit 876d9fa into ojacques:master Oct 4, 2024
@ojacques
Copy link
Owner

ojacques commented Oct 4, 2024

@onuralpszr
Copy link
Contributor Author

onuralpszr commented Oct 4, 2024

@ojacques thank you but can you YANK version 2.4.0 at pypi. So that pypi also can help people and warn as well. or removal would be great as well (just a suggestion)

@ojacques
Copy link
Owner

ojacques commented Oct 5, 2024

@ojacques thank you but can you YANK version 2.4.0 at pypi. So that pypi also can help people and warn as well. or removal would be great as well (just a suggestion)

2.4.0 has been yanked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants