Updates for compatibility with EU Frankfurt AWS Region #49
Conversation
There was a problem hiding this comment.
Hey @jgavin! Thanks for the contribution!
I've pointed out a couple of things in the review. I'm going to update the Java AWS SDK dependency and see what should be done to solve these issues.
| val euCentral = Region.EU_Frankfurt.toString | ||
|
|
||
| //Correcting for fact that region enum resolves to null when provided US_STANDARD (us-east-1) | ||
| val correctedRegion = if(region == null) "us-east-1" else region |
There was a problem hiding this comment.
I think this is not a good workaround. A null may appear here for another reason and it should be silently replaced with this particular region value. Besides, US_Standard is not just a synonym for US_EAST_1. From the AWS Java SDK docs:
This is the default Amazon S3 Region. All requests sent to s3.amazonaws.com go to this region unless a location constraint is specified when creating a bucket. The US Standard Region automatically places data in either Amazon's east or west coast data centers depending on which one provides the lowest latency.
The region argument here is just a string, so you can pass either "us-east-1" directly or using the Regions enum or some other way. My point is that this is not an issue this plugin should solve.
| region match { | ||
| case euCentral => s"""https://s3.${correctedRegion}.amazonaws.com/${bucketPath}""" | ||
| case _ => s"""https://s3-${correctedRegion}.amazonaws.com/${bucketPath}""" | ||
| } |
There was a problem hiding this comment.
Thanks for pointing it out, I didn't know that these patterns vary. Now looking through the docs I see that it's also different for China (having .cn suffix). So I want to find a way to get this prefix by the AWS SDK means.
There was a problem hiding this comment.
Here's a solution:
> import com.amazonaws.services.s3._, model._
> Region.EU_Frankfurt.toAWSRegion.getServiceEndpoint(AmazonS3.ENDPOINT_PREFIX)
s3.eu-central-1.amazonaws.com
> Region.EU_Ireland.toAWSRegion.getServiceEndpoint(AmazonS3.ENDPOINT_PREFIX)
s3-eu-west-1.amazonaws.com
> Region.CN_Beijing.toAWSRegion.getServiceEndpoint(AmazonS3.ENDPOINT_PREFIX)
s3.cn-north-1.amazonaws.com.cn
> Region.US_Standard.toAWSRegion.getServiceEndpoint(AmazonS3.ENDPOINT_PREFIX)
s3.amazonaws.comIt handles the different prefixes (./- and .cn) and also works for US_Standard (for some reason Region.US_Standard.toAWSRegion doesn't throw a NPE).
I guess, I'll also change the type of the parameter to com.amazonaws.regions.Region to avoid these problems.
|
I'm going to merge it and change thing then myself before cutting a new release. Thanks for bringing this up @jgavin 👍 |
This PR addresses this issue: #47 around not being able to publish artifacts in the EU Frankfurt region.