Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better serialization #53

Merged
merged 6 commits into from
Aug 22, 2015
Merged

better serialization #53

merged 6 commits into from
Aug 22, 2015

Conversation

eparejatobes
Copy link
Contributor

Same as in #45, we need record serialization to Map[String,V] with a couple of possible errors:

  • Key already there
  • error serializing value to V

@eparejatobes
Copy link
Contributor Author

waiting for #45

@eparejatobes
Copy link
Contributor Author

working, just needs to have some tests for serialization failing. It would also be nice to have a serializeTo where you pass a map of the given type (and check existing key for that)

@eparejatobes
Copy link
Contributor Author

I'm happy with this. LGTM

laughedelic
laughedelic reviewed Aug 21, 2015
View reviewed changes
src/main/scala/cosas/ops/records/Conversions.scala
@@ -7,7 +7,7 @@ import ops.typeSets._
Cannot parse fields
${PS}
from a Map[String, ${V}].
Probably you haven't provided property parsers for all properties involved.
Probably you haven't provided property parsers for all properties in ${PS}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If PS is large, this won't look not nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough,changing it

@eparejatobes
Copy link
Contributor Author

merging

@eparejatobes eparejatobes merged commit 832d1d8 into master Aug 22, 2015
@eparejatobes eparejatobes deleted the feature/better/serialization branch August 22, 2015 12:16
eparejatobes added a commit that referenced this pull request Sep 3, 2015
@eparejatobes
Setting version to 0.7.0:
f43dc9c 
The main changes in this release are

- remove property holders and related abstractions
- better parsing and serialization support for typesets of denotations (including records)
- better support for invariant equality
- reducing dependencies

Highlights are #50, #53, #55, #56, #48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement feature record
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eparejatobes @laughedelic