Colorize Uninstall, Improve Colorization of Install and Upgrade #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if [ -f ~/.zshrc ] || [ -h ~/.zshrc ] | ||
| then | ||
| echo "\033[0;33mFound ~/.zshrc.\033[0m \033[0;32]Backing up to ~/.zshrc.pre-oh-my-zsh\033[0m"; |
There was a problem hiding this comment.
I don't know why these lines had semicolons. I decided to make them consistent with the rest of the lines.
Replace color codes with easy to understand names. Improve wording of some messages.
|
Rebased. |
|
Currently can't merge this... |
|
I'm really busy right now, ill update it if I have some free time. |
|
No traction on this in 6 months. Re-open when/if we can merge this. |
|
Meh, if someone really cares about this, let me know... |
nguymin4
pushed a commit
to nguymin4/oh-my-zsh
that referenced
this pull request
Jul 26, 2024
* Improve the debug prompt (PS4) Add colors, to highlight the current function and de-empasize line numbers. Add an extra line number (`%I`) which represents the line number in the file where the code resides (by default, only the function line number is shown, making it hard(er) to find the relevant code). Repeat the + character to indicate the current execution depth, e.g. when a function calls another, the depth is increased. This allows you to quickly see which function invoked which. * Add filename to debug prompt Add filename (without path) to the debug prompt, when applicable and makes sure to avoid displaying duplicate information. Say, when a file is being parsed, both %N and %x contain the same value (file path). In this case, we only show one value. There is a slight cost to doing the extra processing when testing in iTerm (unscientific benchmark): zsh -x 0.30s user 0.14s system 57% cpu 0.754 total vs zsh -x 0.49s user 0.16s system 65% cpu 0.988 total I think this is within an acceptable range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I've made improvements to #393. Now the code looks (a bit) nicer, and it's easier to change if you don't like some decision I've made.
Enjoy!