Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: tmux, goenv, pyenv #266

Merged
merged 11 commits into from
Dec 24, 2021
Merged

Plugins: tmux, goenv, pyenv #266

merged 11 commits into from
Dec 24, 2021

Conversation

chopnico
Copy link
Contributor

I use these programs quite extensively and these simple plugins have been quite stable.

akinomyoga
akinomyoga requested changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good. I have a few minor comments.

plugins/tmux-autoattach/tmux-autoattach.plugin.sh Outdated Show resolved Hide resolved
plugins/tmux-autoattach/README.md Outdated Show resolved Hide resolved
plugins/tmux-autoattach/tmux-autoattach.plugin.sh Outdated Show resolved Hide resolved
@chopnico
removed checks and updated read me
d377f9b 
- checks have been removed to in favor of conditional plugin loading
- .gitignore has been updated to ignore .tmp files
- main README has been updated to reflect conditional plugin loading
- tmux-autoattach plugin README has been updated to reflect
  conditional plugin loading options
akinomyoga
akinomyoga reviewed Dec 24, 2021
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates! I think this is now almost ready to be merged, but I have two additional suggestions. These are just optional, so you do not have to adopt them. I'd like to hear your opinion on them if any. Thank you!

README.md Show resolved Hide resolved
plugins/tmux-autoattach/README.md Outdated Show resolved Hide resolved
chopnico and others added 2 commits December 24, 2021 07:20
@chopnico @akinomyoga
Update plugins/tmux-autoattach/README.md
772c774 
Co-authored-by: Koichi Murase <[email protected]>
@chopnico
statement about conditional plugins loading
a001673 
- bashrc.osh-template has been updated to explain how to
  conditionally load plugins
@akinomyoga
Copy link
Contributor

Thank you! Is there anything else? If not, I will merge it after adding some trivial changes.

@akinomyoga akinomyoga merged commit dde7ea6 into ohmybash:master Dec 24, 2021
@akinomyoga
Copy link
Contributor

Thank you! I have merged it!

FWIW, I have noticed that you have actually worked in the master branch. It's fine for me, but it is generally nicer to work in a branch of a different name for a PR. Otherwise, the maintainer needs to temporarily rename or delete the true master branch in their local repository in order to edit the PR branch (or need to create another local repository).

Thank you again for making the PR, for your swift replies, and for your patience with a number of requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chopnico @akinomyoga