Time fix #810
Merged
Time fix #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like an invalid call was used. |
|
Ah, can't use |
ohler55
approved these changes
Aug 23, 2022
wintonpc
added a commit
to wintonpc/oj
that referenced
this pull request
Aug 31, 2023
wintonpc
added a commit
to wintonpc/oj
that referenced
this pull request
Aug 31, 2023
wintonpc
added a commit
to wintonpc/oj
that referenced
this pull request
Aug 31, 2023
wintonpc
added a commit
to wintonpc/oj
that referenced
this pull request
Aug 31, 2023
ohler55
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Don't assume xmlschema nanoseconds and don't fudge fractional seconds * Remove unused defs from #810 * Fixed clang-format violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the time related failures on TruffleRuby I noticed that Unix times with offsets do not actually round trip correctly on MRI either. This PR creates times by using
Time.atwith nanoseconds and an offset, and avoids the precision issues of the old method. I've also added an assertion to the tests that the loaded object is equal to the one originally dumped out.