Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hacks for loading investigations in Consultation Form, updated type definitions #8416

Merged

Conversation

Nithin9585
Copy link
Contributor

@Nithin9585 Nithin9585 commented Aug 24, 2024

Required Backends

Proposed Changes

  • Removed hacks for loading investigations in Consultation Form
  • Updated type definitions to removed old unused prescription related attributes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to the issue.
  • Request for Peer Reviews.
  • Completion of QA.

Copy link

vercel bot commented Aug 24, 2024

@Nithin9585 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1acde79
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66d0b37a3259660008a30d73
😎 Deploy Preview https://deploy-preview-8416--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause of the issue is that the backend defaults to dict if not specified.

https://github.com/ohcnetwork/care/blob/develop/care/facility/models/patient_consultation.py#L83

image image

@rithviknishad
Copy link
Member

@Nithin9585 ohcnetwork/care#2410 would be solving the root cause. You may undo these changes and instead update the PR to remove the following hack in the consultation form instead: https://github.com/ohcnetwork/care_fe/blob/develop/src/Components/Facility/ConsultationForm.tsx#L410-L412

@rithviknishad rithviknishad requested a review from a team as a code owner August 29, 2024 17:27
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit a7da872
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66d0af83bc5e400008110f51

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 29, 2024
@rithviknishad rithviknishad changed the title Fix TypeError: s.map is not a function in InvestigationBuilder component Removed hacks for loading investigations in Consultation Form, updated type definitions Aug 29, 2024
@rithviknishad rithviknishad removed changes required Deploy-Failed Deplyment is not showing preview labels Aug 29, 2024
@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Aug 29, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

LGTM

@rithviknishad rithviknishad merged commit 7a82416 into ohcnetwork:develop Sep 21, 2024
27 of 28 checks passed
Copy link

@Nithin9585 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Nithin9585 Nithin9585 deleted the issues/8008/fix-map-error branch September 21, 2024 04:48
khavinshankar pushed a commit that referenced this pull request Sep 23, 2024
…d type definitions (#8416)

---------

Co-authored-by: rithviknishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants