Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sample test type filter to sample management system #1883

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Added sample test type filter to sample management system #1883

merged 2 commits into from
Oct 25, 2021

Conversation

Apurva-Nagar
Copy link
Contributor

@Apurva-Nagar Apurva-Nagar requested a review from a team October 4, 2021 18:10
@Apurva-Nagar
Copy link
Contributor Author

Related backend PR - ohcnetwork/care#629

@samholics
Copy link

Not filtering out the test_type from whole request list when applying filter as "sample_test_type"
https://deploy-preview-1883--dreamy-fermat-b5024e.netlify.app/sample?status=&result=&facility=&sample_type=3

@Apurva-Nagar
Copy link
Contributor Author

@samholics There is a backend PR too, changes will reflect once it has been merged.

@nihal467 nihal467 added the question Further information is requested label Oct 8, 2021
@bodhish bodhish added needs review and removed question Further information is requested labels Oct 9, 2021
@nihal467
Copy link
Member

@Apurva-Nagar @gigincg check the merge conflict

@nihal467
Copy link
Member

@Apurva-Nagar @gigincg tested, PR is working, check the merge conflict

@gigincg
Copy link
Member

gigincg commented Oct 22, 2021

@Apurva-Nagar Can you fix the Merge Conflicts, The PR looks good to merge otherwise!

@gigincg gigincg merged commit e049605 into develop Oct 25, 2021
@khavinshankar khavinshankar deleted the fix1833 branch December 1, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter in sample test management for "sample_test_type"
5 participants
@Apurva-Nagar @samholics @nihal467 @gigincg @bodhish