Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues when qr_code_id is a blank string and show message for unique integrity error #777

Merged
merged 2 commits into from
May 26, 2022
Merged

fix issues when qr_code_id is a blank string and show message for unique integrity error #777

merged 2 commits into from
May 26, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented May 21, 2022

@sainak sainak requested a review from a team as a code owner May 21, 2022 20:31
@sainak sainak changed the title fix issues when qr_code_id is blank string and message for unique integrity error fix issues when qr_code_id is a blank string and show message for unique integrity error May 21, 2022
Marmik2003
Marmik2003 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@Marmik2003 Marmik2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

vigneshhari
vigneshhari approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without testing

@vigneshhari vigneshhari merged commit e804cc9 into ohcnetwork:master May 26, 2022
@sainak sainak deleted the fe_issue-2422 branch May 28, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marmik2003 Marmik2003 Marmik2003 approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new asset throws an error
3 participants
@sainak @vigneshhari @Marmik2003