Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added localstack s3 buckets for local environment #752

Merged
merged 3 commits into from
May 23, 2022

Conversation

Marmik2003
Copy link
Contributor

  1. added localstack in docker-compose.local.yaml
  2. added bucket-setup.sh to create buckets upon running container

@Marmik2003 Marmik2003 requested a review from a team as a code owner May 18, 2022 11:45
@Marmik2003
Copy link
Contributor Author

fixes #751

@gitguardian
Copy link

gitguardian bot commented May 20, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Private Key 613009a config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

docker-compose.local.yaml Outdated Show resolved Hide resolved
docker-compose.local.yaml Outdated Show resolved Hide resolved
Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have not verified.

@vigneshhari vigneshhari merged commit 3b26a50 into ohcnetwork:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants