Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new asset actions and clenup asset_monitor task #2411

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 29, 2024

Proposed Changes

  • optimized asset monitor
  • added new methods to asset classes
  • fix sending 200 even in error requests
  • add support for camera uptime in new middlewares

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@sainak sainak requested a review from a team as a code owner August 29, 2024 18:42
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (c1a74f2) to head (112663d).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
care/facility/tasks/asset_monitor.py 11.11% 8 Missing ⚠️
care/utils/assetintegration/base.py 20.00% 4 Missing ⚠️
care/utils/assetintegration/hl7monitor.py 33.33% 2 Missing ⚠️
care/utils/assetintegration/onvif.py 33.33% 2 Missing ⚠️
care/utils/assetintegration/ventilator.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2411      +/-   ##
===========================================
+ Coverage    63.82%   64.10%   +0.27%     
===========================================
  Files          239      241       +2     
  Lines        13416    13583     +167     
  Branches      1909     1944      +35     
===========================================
+ Hits          8563     8707     +144     
- Misses        4505     4516      +11     
- Partials       348      360      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 66cdc38 into develop Aug 30, 2024
4 checks passed
@vigneshhari vigneshhari deleted the sainak/feat/new-asset-methods branch August 30, 2024 07:13
@sainak sainak self-assigned this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants