Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creating notifications if shifting_approving_facility is not available #2372

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 20, 2024

Proposed Changes

  • check shifting_approving_facility before creating a notification, shifting_approving_facility is optional in peacetime mode

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner August 20, 2024 18:02
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (fd2e954) to head (a1bb8c1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2372   +/-   ##
========================================
  Coverage    63.86%   63.86%           
========================================
  Files          239      239           
  Lines        13439    13439           
  Branches      1914     1914           
========================================
  Hits          8583     8583           
  Misses        4508     4508           
  Partials       348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 3a5780f into develop Aug 23, 2024
11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/shift-notifications branch August 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility.DoesNotExist: Facility matching query does not exist.
2 participants