Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Nurses to clear their home facility #2206

Merged

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

  • Allow Nurses to clear the home facility for their own user only.

Associated Issue

Frontend PR: #7738

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.48%. Comparing base (51ce81e) to head (21a0eb7).
Report is 119 commits behind head on develop.

Files Patch % Lines
care/users/api/viewsets/users.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2206      +/-   ##
===========================================
+ Coverage    62.20%   63.48%   +1.28%     
===========================================
  Files          221      238      +17     
  Lines        12204    13264    +1060     
  Branches      1742     1886     +144     
===========================================
+ Hits          7591     8421     +830     
- Misses        4305     4490     +185     
- Partials       308      353      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Jun 4, 2024

LGTM

@nihal467 nihal467 added the P2 label Jun 4, 2024
care/users/api/viewsets/users.py Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902
Copy link
Contributor Author

@sainak @rithviknishad done, could you recheck the new conditions

@gigincg gigincg merged commit cda75bb into ohcnetwork:develop Jun 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants