Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ABDM into Plug - Part 1/3 #2161

Merged
merged 84 commits into from
Sep 6, 2024
Merged

Convert ABDM into Plug - Part 1/3 #2161

merged 84 commits into from
Sep 6, 2024

Conversation

khavinshankar
Copy link
Member

This pull request represents the first phase of converting the ABDM system into a plug. The primary focus of this PR is to refactor the relationship between the ABHA number and the patient model, alongside improvements to signal handling and routing. Detailed changes include:

  • Model Relationship Reversal: Changed the relationship dynamics by moving the abha_number field from the patient model to the abha_number model. This involves making patient a field within the abha_number model to better align with our new architecture.

  • Signal Creation for Care Context: Implemented a new signal that triggers the creation of a care context whenever a consultation is saved. This enhances the functionality and integration of care context within our system.

  • ABHA Number API Enhancements: Introduced a new abha_number viewset, serializer, and routes. These additions are designed to streamline the handling and accessibility of ABHA numbers within our system.

This PR lays the groundwork for the subsequent phase, which will further integrate and optimize the ABDM plug system.

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2024

@vigneshhari conditionally approving it for review alone by @sainak @rithviknishad & @vigneshhari, since ABDM fetched patient record takes some time to reflect in the platform (pending test)

@khavinshankar khavinshankar requested a review from sainak July 4, 2024 04:55
@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024

LGTM

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge conflicts need to be resolved

@khavinshankar khavinshankar changed the title Convert ABDM into Plug - Part 1/2 Convert ABDM into Plug - Part 1/3 Aug 23, 2024
Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a request for optimisation, resolve the merge conflicts as well.

care/abdm/api/viewsets/abha_number.py Outdated Show resolved Hide resolved
@sainak sainak merged commit e011af5 into develop Sep 6, 2024
9 of 10 checks passed
@sainak sainak deleted the pre-abdm-plug branch September 6, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants