-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ABDM into Plug - Part 1/3 #2161
Conversation
@vigneshhari conditionally approving it for review alone by @sainak @rithviknishad & @vigneshhari, since ABDM fetched patient record takes some time to reflect in the platform (pending test) |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge conflicts need to be resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a request for optimisation, resolve the merge conflicts as well.
This pull request represents the first phase of converting the ABDM system into a plug. The primary focus of this PR is to refactor the relationship between the ABHA number and the patient model, alongside improvements to signal handling and routing. Detailed changes include:
Model Relationship Reversal: Changed the relationship dynamics by moving the abha_number field from the patient model to the abha_number model. This involves making patient a field within the abha_number model to better align with our new architecture.
Signal Creation for Care Context: Implemented a new signal that triggers the creation of a care context whenever a consultation is saved. This enhances the functionality and integration of care context within our system.
ABHA Number API Enhancements: Introduced a new abha_number viewset, serializer, and routes. These additions are designed to streamline the handling and accessibility of ABHA numbers within our system.
This PR lays the groundwork for the subsequent phase, which will further integrate and optimize the ABDM plug system.