Skip creating event group if all fields are null #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithviknishad
approved these changes
May 8, 2024
| except KeyError: | ||
| value[field] = getattr(object_instance, field, None) | ||
| # if all values in the group are Falsy, skip creating the event for this group | ||
| if all(not v for v in value.values()): |
There was a problem hiding this comment.
Should we consider making the check against None instead?
What if any of the vital is 0 (falsy)?
There was a problem hiding this comment.
yeah makes sense, will update it
6 tasks
vigneshhari
approved these changes
May 13, 2024
vigneshhari
added a commit
that referenced
this pull request
May 15, 2024
* Update max_length for phone numbers to adhere to ITU-T E.164 standard (#2138) * Update max_length for phone numbers to adhere to ITU-T E.164 standard * Clean up an empty line * Adds missing migrations --------- Co-authored-by: rithviknishad <[email protected]> Co-authored-by: Vignesh Hari <[email protected]> * Adds support for doctors and nurses discussions threads in Discussion Notes (#2137) * Adds support for doctors and nurses discussions threads in Discussion Notes * switch to using small integer field * updated and fixes based on test cases * rebase migrations * Remake migrations --------- Co-authored-by: Vignesh Hari <[email protected]> * Allow `audio/mp4` by default (#2094) Co-authored-by: Vignesh Hari <[email protected]> * Bump Dependencies (#2143) * Vigneshhari/bump dependencies (#2145) * Bump Dependencies * Bump Dependencies * Bump Dependencies * Bump Dependencies * Skip creating event group if all fields are null (#2134) * ABDM M3 (#1829) Co-authored-by: Aakash Singh <[email protected]> Co-authored-by: Gigin George <[email protected]> * Increase area of specialisation in doctors (#2102) * update doctor types * Add Migration --------- Co-authored-by: Rithvik Nishad <[email protected]> Co-authored-by: Gigin George <[email protected]> * Added discharge patient filters (#2124) * added discharge patient filters * updated filters --------- Co-authored-by: Vignesh Hari <[email protected]> * converted investigation and investigation group data into JSON (#1912) * converted investigation and investigation group data into JSON * created json files for investigations and investigation_groups * updated investigations.json * fixed json data,command and migrations * fixing migrations * fixing lint issue * update migrations * update migrations --------- Co-authored-by: Aakash Singh <[email protected]> * Drops support for cloning previous log update (#2127) * Drop support for cloning previous log update * undo unrelated changes --------- Co-authored-by: Vignesh Hari <[email protected]> * Change devcontainer make up command to run after start (#2146) Co-authored-by: Vignesh Hari <[email protected]> * Removes unused `current_health` field from Daily Rounds (#2162) Removes unused `current_health` from Daily Rounds Co-authored-by: Vignesh Hari <[email protected]> * Display users list based on user access limitation (#1742) * Refactor get_queryset method in UserViewSet * Used get_accessible_facilities instead of subquery to fetch the facilities linked to the user * fixed failing tests * fix queryset --------- Co-authored-by: Aakash Singh <[email protected]> Co-authored-by: khavinshankar <[email protected]> Co-authored-by: Vignesh Hari <[email protected]> * adds missing merge migrations (#2169) merge migrations --------- Co-authored-by: Bodhish Thomas <[email protected]> Co-authored-by: rithviknishad <[email protected]> Co-authored-by: Vignesh Hari <[email protected]> Co-authored-by: Rithvik Nishad <[email protected]> Co-authored-by: Aakash Singh <[email protected]> Co-authored-by: Khavin Shankar <[email protected]> Co-authored-by: Gigin George <[email protected]> Co-authored-by: Rashmik <[email protected]> Co-authored-by: Shivank Kacker <[email protected]> Co-authored-by: Prafful Sharma <[email protected]> Co-authored-by: Gokulram A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins