Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prescriptions and MAR: Disallow users to perform edits on discharged encounters #2133

Merged
merged 17 commits into from
Sep 22, 2024
Merged

Prescriptions and MAR: Disallow users to perform edits on discharged encounters #2133

merged 17 commits into from
Sep 22, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 7, 2024 •
edited
Loading

Proposed Changes

  • Disallow actions to Prescription and Medicine Administration Records for discharged encounters.
  • Merge prescription related tests to a single file and have dedicated test file for medicine administrations

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad added the In progress Work in progress label May 7, 2024
@rithviknishad rithviknishad removed the In progress Work in progress label May 10, 2024
@rithviknishad rithviknishad marked this pull request as ready for review May 10, 2024 14:40
@rithviknishad rithviknishad requested a review from a team as a code owner May 10, 2024 14:40
@rithviknishad
Copy link
Member Author

Waiting for confirmation regd. whether all remote users needs to be restricted or just remote nurses.

@rithviknishad
Copy link
Member Author

Confirmed. Doctors and Nurses of home facility only must be able to edit consultation related data. Other than doctor notes.

@nihal467 nihal467 added the P1 High priority; urgent label May 21, 2024
nihal467
nihal467 suggested changes May 21, 2024
View reviewed changes
Copy link
Member

@nihal467 nihal467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • admin should be able to edit it irrespective of home facility privileges
  • non-home facility staff is able to create medicine. block that as well in frontend as well backend

@rithviknishad rithviknishad mentioned this pull request May 22, 2024
Merged
6 tasks
@nihal467 nihal467 added P2 and removed P1 High priority; urgent labels May 23, 2024
@nihal467
Copy link
Member

nihal467 commented Jun 4, 2024

@rithviknishad any update on this, is it good for review

@rithviknishad rithviknishad changed the title Prescriptions and MAR: Disallow non-home facility users to perform edits and disallow edits for discharged patients Prescriptions and MAR: Disallow users to perform edits on discharged encounters Jun 6, 2024
@rithviknishad rithviknishad linked an issue Jun 10, 2024 that may be closed by this pull request
Nurse user type without home facility is able to edit prescriptions ohcnetwork/care_fe#7755
Closed
@gigincg
Copy link
Member

gigincg commented Aug 5, 2024

@rithviknishad Waiting for your changes

@rithviknishad rithviknishad removed their assignment Aug 26, 2024
@vigneshhari vigneshhari merged commit 15debe1 into develop Sep 22, 2024
4 of 5 checks passed
@vigneshhari vigneshhari deleted the update-prescription-perms branch September 22, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

@shivankacker shivankacker Awaiting requested review from shivankacker

@nihal467 nihal467 Awaiting requested review from nihal467

@anroopak anroopak Awaiting requested review from anroopak

Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
7 participants
@rithviknishad @nihal467 @gigincg @vigneshhari @shivankacker @sainak @anroopak