-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add age validation in PatientDetailSerializer #1929
Conversation
@sainak here in the tests part I have only considered the case where it gonna fail(dob) , review it and mention if an further changes needed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1929 +/- ##
===========================================
+ Coverage 62.20% 62.52% +0.32%
===========================================
Files 221 223 +2
Lines 12204 12281 +77
Branches 1742 1754 +12
===========================================
+ Hits 7591 7679 +88
+ Misses 4305 4280 -25
- Partials 308 322 +14 ☔ View full report in Codecov by Sentry. |
|
||
is_antenatal = serializers.BooleanField(default=False) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_antenatal = serializers.BooleanField(default=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sainak if we remove this , it is throwing 500 error if "is_antenatal" is not passed in request body as null value is going into the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a correction in the tests
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins