Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create CallMetrics model, viewset and serializer #1004

Closed
wants to merge 2 commits into from
Closed

create CallMetrics model, viewset and serializer #1004

wants to merge 2 commits into from

Conversation

Krishna-Sivakumar
Copy link

Adds a CallMetrics model, serializer and viewset to track whatsapp call utilization.
This PR attempts to resolve issue #738.

@coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Krishna-Sivakumar Krishna-Sivakumar requested a review from a team as a code owner September 6, 2022 13:09
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gigincg
Copy link
Member

gigincg commented Sep 9, 2022

@Krishna-Sivakumar #1001 was created after putting some more thought on the issue. initiated_by and called_at doesn't make any sense since it's the same as created_by and created_at

Can you take up #1001 Test it out and add the waiting for review tag after that. I'm closing this PR.

@gigincg gigincg closed this Sep 9, 2022
@gigincg gigincg reopened this Oct 7, 2022
@gigincg gigincg closed this Oct 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krishna-Sivakumar @gigincg