fix: fix eslint error

ohbug-org · Jul 5, 2023 · 9ae5eb8 · 9ae5eb8
1 parent baa6c93
commit 9ae5eb8
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 21 deletions.
diff --git a/packages/web/app/[locale]/[projectId]/profile/profile.tsx b/packages/web/app/[locale]/[projectId]/profile/profile.tsx
@@ -37,19 +37,25 @@ interface Props {
 const View = ({ views }: Props) => {
   const t = useTranslations('Profile')
   const pageViewTrend = useMemo(
-    () => views.pageViewLastDay > 0
-      ? ((views.pageView - views.pageViewLastDay) / views.pageViewLastDay * 100).toFixed(2)
-      : 100,
-    [views.pageView, views.pageViewLastDay],
+    () => {
+      if (!views) return 100
+      return views.pageViewLastDay > 0
+        ? ((views.pageView - views.pageViewLastDay) / views.pageViewLastDay * 100).toFixed(2)
+        : 100
+    },
+    [views?.pageView, views?.pageViewLastDay],
   )
   const userViewTrend = useMemo(
-    () => views.pageViewLastDay > 0
-      ? ((views.userView - views.userViewLastDay) / views.userViewLastDay * 100).toFixed(2)
-      : 100,
-    [views.userView, views.userViewLastDay],
+    () => {
+      if (!views) return 100
+      return views.pageViewLastDay > 0
+        ? ((views.userView - views.userViewLastDay) / views.userViewLastDay * 100).toFixed(2)
+        : 100
+    },
+    [views?.userView, views?.userViewLastDay],
   )
 
-  if (!(views.pageView || views.pageViewLastDay || views.userView || views.userViewLastDay)) return null
+  if (!(views?.pageView || views?.pageViewLastDay || views?.userView || views?.userViewLastDay)) return null
 
   return (
     <>
@@ -58,7 +64,7 @@ const View = ({ views }: Props) => {
           <StatGroup>
             <Stat>
               <StatLabel>{t('pv')}(PV)</StatLabel>
-              <StatNumber>{views.pageView}</StatNumber>
+              <StatNumber>{views?.pageView}</StatNumber>
               <StatHelpText>
                 <StatArrow type="increase" />
                 {pageViewTrend}%
@@ -67,7 +73,7 @@ const View = ({ views }: Props) => {
 
             <Stat>
               <StatLabel>{t('uv')}(UV)</StatLabel>
-              <StatNumber>{views.userView}</StatNumber>
+              <StatNumber>{views?.userView}</StatNumber>
               <StatHelpText>
                 <StatArrow type="increase" />
                 {userViewTrend}%
@@ -76,18 +82,18 @@ const View = ({ views }: Props) => {
 
             <Stat>
               <StatLabel>{t('activeUser')}</StatLabel>
-              <StatNumber>{views.activeUser ?? 0}</StatNumber>
+              <StatNumber>{views?.activeUser ?? 0}</StatNumber>
             </Stat>
           </StatGroup>
         </Card>
       </Wrapper>
       <Wrapper>
         <Flex gap="8">
           {
-            views.pvPathGroupResult.length > 0 && (
+            views?.pvPathGroupResult.length > 0 && (
               <Card flex="1">
                 <TrendChart
-                  data={views.pvPathGroupResult}
+                  data={views?.pvPathGroupResult}
                   name="number"
                   timeField="value"
                   title={
@@ -104,10 +110,10 @@ const View = ({ views }: Props) => {
             )
           }
           {
-            views.pvReferrerGroupResult.length > 0 && (
+            views?.pvReferrerGroupResult.length > 0 && (
               <Card flex="1">
                 <TrendChart
-                  data={views.pvReferrerGroupResult}
+                  data={views?.pvReferrerGroupResult}
                   name="number"
                   timeField="value"
                   title={
@@ -168,10 +174,10 @@ const Trend = ({ trends }: Props) => {
 }
 const Events = ({ project }: Props) => {
   const { data, size, setSize, isLoading, isReachingEnd } = useInfinite<Event>(
-    index => serviceGetEventByProjectId({ projectId: project.id, page: index + 1 }),
+    index => serviceGetEventByProjectId({ projectId: project!.id, page: index + 1 }),
     {
-      enabled: project.id !== undefined,
-      deps: [project.id],
+      enabled: project?.id !== undefined,
+      deps: [project?.id],
     },
   )
 

diff --git a/packages/web/app/[locale]/auth/signin/page.tsx b/packages/web/app/[locale]/auth/signin/page.tsx
@@ -25,6 +25,7 @@ async function getInviter(userId: string | null, projectId: string | null) {
       }
     }
   }
+  return undefined
 }
 
 export const metadata: Metadata = { title: 'SignIn | Ohbug' }

diff --git a/packages/web/components/issueList.tsx b/packages/web/components/issueList.tsx
@@ -366,7 +366,7 @@ const IssueList: FC<Props> = ({ empty }) => {
       </CheckboxGroup>
 
       {
-        data?.length > 0 && (
+        !!data?.length && (
           <Flex
             alignItems="center"
             justifyContent="space-between"

diff --git a/packages/web/components/releaseList.tsx b/packages/web/components/releaseList.tsx
@@ -52,7 +52,7 @@ const ReleaseList: FC<Props> = ({ releases, mutate }) => {
               direction="column"
               flex="1"
             >
-              <Link fontWeight="semibold">{release.appVersion}</Link>
+              <Text fontWeight="semibold">{release.appVersion}</Text>
               <Text
                 as="span"
                 color="dimgray"
-Original file line number
+Diff line change
@@ Expand Up @@
           }
         }
       }
+      return undefined
     }
     export const metadata: Metadata = { title: 'SignIn | Ohbug' }
@@ Expand Down @@