Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plugin for usage with 0.4.x #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josegonzalez
Copy link

No description provided.

@caioariede
Copy link

👍

@sbehrends
Copy link

Is this branch working? I added it as a plugin to Dokku, volumes are generated but they will never mount on docker.

@josegonzalez
Copy link
Author

No idea, all I did was a basic upgrade.

@sbehrends
Copy link

It's not mounting the volumes on docker. Looks like the env var is not being passed as a config.

@ebeigarts
Copy link

There is no docker-argshook anymore, instead there is docker-args-deploy, docker-args-build, docker-args-run

root@dokku:/var/lib/dokku/plugins/enabled/volume# ln -s docker-args docker-args-deploy
root@dokku:/var/lib/dokku/plugins/enabled/volume# ln -s docker-args docker-args-run

@sbehrends
Copy link

Good solution ;)
Any clue on how fixing permissions? One container writes files with it's gid and on next boot gid changes and dont have permissions

@ebeigarts
Copy link

@sbehrends i'm not having this issue (dokku 0.4.1, docker 1.8.2 aufs)

@sbehrends
Copy link

Had to add "-e USER=nobody" so it's always same users that writes that volume.

@josegonzalez
Copy link
Author

Updated the docker args stuff for 0.4.x.

@ebeigarts
Copy link

docker-args-build got my volumes wiped out, the herokuish build process does some weird cleaning after build process...

@josegonzalez
Copy link
Author

Okay, so I'll drop that one.

@josegonzalez
Copy link
Author

bump

@EpicVoyage
Copy link

I installed dokku-volume and then applied this patch against /var/lib/dokku/plugins/available/volume. Once I realized that docker-ags-deploy needed chmod +x, everything began to work correctly.

This patch has my vote.

@alessio
Copy link
Contributor

alessio commented Jan 6, 2016

👍

@cveilleux
Copy link

+1 please merge

@Kikobeats
Copy link

I tested that @josegonzalez PR works fine in the last version of dokku, so @ohardy go ahead!

@Kikobeats
Copy link

why not merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants