makes the ML link open in a new window

ogupte · May 5, 2020 · d56debc · d56debc
1 parent ccf4bb8
commit d56debc
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/x-pack/plugins/apm/public/components/app/ServiceMap/Popover/Contents.tsx b/x-pack/plugins/apm/public/components/app/ServiceMap/Popover/Contents.tsx
@@ -165,7 +165,9 @@ export function Contents({
             </EuiFlexGroup>
           </ContentLine>
           <ContentLine>
-            <MLJobLink jobId={jobId}>{ANOMALY_DETECTION_LINK}</MLJobLink>
+            <MLJobLink external jobId={jobId}>
+              {ANOMALY_DETECTION_LINK}
+            </MLJobLink>
           </ContentLine>
           <EuiHorizontalRule margin="xs" />
         </FlexColumnItem>

diff --git a/x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLJobLink.tsx b/x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLJobLink.tsx
@@ -16,7 +16,9 @@ interface PropsJobId {
   jobId: string;
 }
 
-type Props = PropsServiceName | PropsJobId;
+type Props = (PropsServiceName | PropsJobId) & {
+  external?: boolean;
+};
 
 export const MLJobLink: React.FC<Props> = props => {
   const jobId =
@@ -32,6 +34,7 @@ export const MLJobLink: React.FC<Props> = props => {
       children={props.children}
       query={query}
       path="/timeseriesexplorer"
+      external={props.external}
     />
   );
 };
diff --git a/x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.tsx b/x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.tsx
@@ -22,9 +22,10 @@ interface Props {
   query?: MlRisonData;
   path?: string;
   children?: React.ReactNode;
+  external?: boolean;
 }
 
-export function MLLink({ children, path = '', query = {} }: Props) {
+export function MLLink({ children, path = '', query = {}, external }: Props) {
   const { core } = useApmPluginContext();
   const location = useLocation();
 
@@ -41,5 +42,12 @@ export function MLLink({ children, path = '', query = {} }: Props) {
     hash: `${path}?_g=${rison.encode(risonQuery as RisonValue)}`
   });
 
-  return <EuiLink children={children} href={href} />;
+  return (
+    <EuiLink
+      children={children}
+      href={href}
+      external={external}
+      target={external ? '_blank' : undefined}
+    />
+  );
 }