Factor Download() out of DownloadPython() & DownloadMiniconda() #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Retry once to get the error message if any at the last try | ||
| $webclient.DownloadFile($url, $filepath) | ||
| } | ||
| $filepath = Download $filename $url | ||
| return $filepath |
There was a problem hiding this comment.
Could you add a revision to convert this line to using 4 space indent like the rest of the file?
|
This change looks good. It might conflict with my patch #19 , but this patch was first so it should be merged first ;-) |
| @@ -42,6 +40,14 @@ function DownloadPython ($python_version, $platform_suffix) { | |||
| } | |||
There was a problem hiding this comment.
Do you want these lines converted to 4 space indent as well?
EDIT: I mean lines 32-39, expand the collapsed section to see them
|
Sorry I merged them the other way around. Could you please rebase on the current master? |
moreati
force-pushed
the
install_refactor
branch
from
be54ec3 to
a323d4d
Compare
|
Rebased, including indentation fixes |
Open
|
+1 |
|
Thanks! Merging. |
ogrisel
added a commit
that referenced
this pull request
Aug 7, 2015
Factor Download() out of DownloadPython() & DownloadMiniconda()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.