Add support for local models (OpenAI compatible) #157
+97
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browningluke
commented
Oct 21, 2024
Comment on lines
+111
to
+114
| message = [ | ||
| {"role": "system", "content": system_prompt}, | ||
| {"role": "user", "content": user_prompt} | ||
| ] |
There was a problem hiding this comment.
This may be a Jan-specific issue, but requests in format: {"type": "text", "text": system_prompt} do not work, since only text is supported (images are not). However, I left the image option toggle and the request format for that alone, in case any OpenAI compatible servers do support images.
browningluke
commented
Oct 21, 2024
Comment on lines
+259
to
+268
| base_url = None | ||
|
|
||
| if 'Local OpenAI' in translator_key: | ||
| base_url = self.settings.ui.llm_widgets['local_oai_url_input'].text() | ||
|
|
||
| if not base_url and translator_key == "Local OpenAI Server": | ||
| raise ValueError(f"Base URL not found for translator: {translator_key}") | ||
|
|
||
| return base_url |
There was a problem hiding this comment.
Added logic to pull the base_url in translator.py and pass it to the get_llm_client() helper, rather than have the helper need to access the settings pane.
browningluke
commented
Oct 21, 2024
|
|
||
| local_oai_model_input = MLineEdit() | ||
| local_oai_model_input.setFixedWidth(400) | ||
| local_oai_model_input.setPlaceholderText("llama3.1-8b-instruct") |
There was a problem hiding this comment.
Using llama3.1-8b-instruct as the default model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using any of the current LLMs for translation is expensive, since you pay per-token for API calls. This PR adds an option to allow for a "Local OpenAI server" to be used instead.
This should allow for using locally hosted LLMs using tools such as vLLM or Jan. I have had success translating pages using Llama-3.1-8B-Instruct through Jan. Importantly, I have not tried vLLM, as I am running an M1 Mac, but it should work. Anyone else able to verify this would be much appreciated.
Addresses issue #150
This PR should be functional, but is marked as draft as the README still needs to be updated.