Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build fail with i686 toolchain #33

Closed
wants to merge 1 commit into from
Closed

Fix build fail with i686 toolchain #33

wants to merge 1 commit into from

Commits on Dec 13, 2017

  1. Fix build fail with i686 toolchain 

    The problem appeared to be the calling convention of of the kernel32 DLL
function and u64 being used even with i686 (32-bit) toolchain. On
Windows, a `DWORD` is always 32-bit (u32) even on a 64-bit system
(x86_64). The `GetStdHandle` declaration was using a u64.

Additionally, the `system` calling convention needed to be added because
in 64-bit environments (x86_64), the calling convention is "C" but in
32-bit environments the calling convention is "stdcall". The `system`
calling convention automatically handles the difference depending on the
environment/toolchain.
    @volks73
    volks73 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    46495a5 View commit details
    Browse the repository at this point in the history