Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Color alias to Colour #11

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Implement Color alias to Colour #11

merged 1 commit into from
Mar 18, 2016

Conversation

DavidJFelix
Copy link
Contributor

I thought this was sufficiently silly, so feel free to reject this PR.

Rust is nice because we can alias exports and we don't have to argue over the Queen's spelling vs. patriotic way to spell color.

I was able to verify that this does allow for one to use ansi_color::Color::Green

This PR may be accompanied by changes to the readme or modifications to the version.

ogham added a commit that referenced this pull request Mar 18, 2016
Implement Color alias to Colour
@ogham ogham merged commit f350ab2 into ogham:master Mar 18, 2016
@ogham
Copy link
Owner

ogham commented Mar 18, 2016

It is sufficiently silly, but I'm going to merge it anyway! A lifetime of writing 'colour' in CSS means it's only fair. Thanks 👍

@ogham
Copy link
Owner

ogham commented Mar 18, 2016

(I won't be able to publish to crates.io until later today, sorry about that)

@DavidJFelix
Copy link
Contributor Author

As a side note, this is one of the niceties of the rust type system. Types and modules can be aliased to better convey meaning. While Colour has a very apparent meaning, we can make libraries transcend written language while still providing type safety and clarity to users! Coming soon: Sanskrit translation! 😛

@ogham
Copy link
Owner

ogham commented Mar 18, 2016

Maybe one day, maybe one day...

I did want to call Colour something that couldn't be spelt differently, but I couldn't think of anything that fit.

@DavidJFelix
Copy link
Contributor Author

I did want to call Colour something that couldn't be spelt differently, but I couldn't think of anything that fit.

"Hue"? I personally like Color/Colour. I didn't have much problem with either spelling (I wrote it once as a use line) I just noticed a large aside in the README and thought "it doesn't have to be like this... I like tea, but also cheese burgers.

🇺🇸 ❤️ 🇬🇧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants