Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons for .pm similar to .pl #1076

Merged
merged 2 commits into from
Jul 16, 2022
Merged

Added icons for .pm similar to .pl #1076

merged 2 commits into from
Jul 16, 2022

Conversation

cab-1729
Copy link
Contributor

Perl modules end with the .pm extension. These are files imported by Perl scripts as objects. Most file managers I know display the same icon for .pm and .pl files.

@ariasuni
Copy link
Collaborator

Hi, there is already a similar pull request open but its author seems not responsive.

Do you think you could take the types mentioned here into account, and add the relevant ones to your pull request?

@cab-1729
Copy link
Contributor Author

I've added the same icon for pm, t, pod, and plx.

I think we should not concern ourselves with the fact that plx is used in legacy code, given that a large portion of programmers interacting with perl are dealing with legacy code.

t is just perl code used for testing.

You are right about pod being documentation, but Plain Old Documentation(syntax used by pod files) is a sort of markup language often used inside of perl scripts instead of separate files. The perl interpreter ignores what is written with this syntax (similar to comments), hence .pod files are technically valid perl code. So it might make sense for them to have the same icon. Besides that, there isn't really another good alternative I can think of.

With regard to .xs files. These files allow perl to interact with C/C++ subroutines. It isn't really perl code, but the syntax is sort of like a combination of C and Perl. So I didn't give it the same icon. I think it is better to ignore xs files for now, because I couldn't find an icon that seems appropriate for those files.

@ariasuni ariasuni merged commit 7e4944c into ogham:master Jul 16, 2022
@ariasuni
Copy link
Collaborator

OK, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants