Try canonicalisation when converting File to Dir #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this canonicalisation, if the directory is a symbolic link to
another directory, later at
reorient_target_path
[1], File and pathargument look like:
...where /tmp/test2 is a symlink to /tmp/test1 and command being used is
exa -laa /tmp/test2
.So the result of
dir.join(&*path)
becomes/tmp/test2/test1
, whichdoesn't exist.
The canonicalisation also makes the behaviours of
exa -laa /tmp/test2
and
exa -laa /tmp/test2/
consistent, where.
is not treated as asymlink in either case. This is a bit different from coreutils
ls
though.
Closes #952.
[1]
exa/src/fs/file.rs
Lines 215 to 217 in 42659f9