[v1.14.x] prov/verbs: track transmit requests, so we can report failures on shutdown #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrink the size of struct vrb_context by combining disjointly used fields into a union. Replace the use of generic OFI flags with a verbs specific enum. And remove setting unnecessary fields in call paths. The vrb_context structure will be expanded to track send operations in a follow on patch. These changes keep the structure size to castable with struct fi_context. Even though there is currently no requirement to restrict vrb_context to that size. Signed-off-by: Sean Hefty <[email protected]>
Add transmit operations to a software SQ when posting, and remove them when handling the completion. Generate flushed completions for any outstanding transmit operations when shutting down an endpoint. This update ensures that all posted sends will generate a completion to the application. This fixes an issue with DAOS where a send operation never completes in the case that the peer has crashed, resulting in the local application hanging. Signed-off-by: Sean Hefty <[email protected]>
shefty
changed the title
|
Fixes #7287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.