This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
kiwix-hotspot: use shutil to find correct bin path. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Ark74 ; we're working on a new (command-line only for now) version of the tool and I can't quite commit the time to test your PR and make a new release. I'll come back to this later. |
|
No problem, thanks for taking the time to mention it. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting on Ubuntu 22.04
mount.exfat link to binary mount.exfat-fuse no longer exists,
Another change is the exfat-utils package now provided by exfatprogs changes binaries location,
So, maybe we can use shutil.which to find the binary path regardless of the version.