Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Time Management #5076

Closed
wants to merge 1 commit into from

Conversation

FauziAkram
Copy link
Contributor

@FauziAkram FauziAkram commented Feb 26, 2024

Simplify Time Management

Instead of having a formula for using extra time with larger increments.
Simply set it to 1 when the increment is lower than 0.5s and to 1.1 when the increment is higher.

The values can later on be further improved.

Passed STC:
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 27488 W: 7077 L: 6848 D: 13563
Ptnml(0-2): 96, 3041, 7267, 3218, 122
https://tests.stockfishchess.org/tests/view/65d25d3c1d8e83c78bfd9293

Passed LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 137568 W: 34612 L: 34512 D: 68444
Ptnml(0-2): 60, 14672, 39221, 14770, 61
https://tests.stockfishchess.org/tests/view/65d2a72c1d8e83c78bfd97fa

Passed VLTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 139650 W: 35229 L: 35134 D: 69287
Ptnml(0-2): 33, 14227, 41218, 14306, 41
https://tests.stockfishchess.org/tests/view/65d7d7d39b2da0226a5a205b

Passed also the TCEC TC style suggested by vondele:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 134150 W: 34278 L: 34163 D: 65709
Ptnml(0-2): 561, 15727, 34444, 15722, 621
https://tests.stockfishchess.org/tests/view/65e4ca73416ecd92c162a57d

bench: 1303971
@XInTheDark
Copy link
Contributor

I think it's much better to let the VLTC test finish. Non-regression can't be statistically proved without the actual LLR.

@FauziAkram
Copy link
Contributor Author

FauziAkram commented Feb 26, 2024

@XInTheDark Ok, resumed it, and now completed (Passed).

@vondele
Copy link
Member

vondele commented Mar 3, 2024

can you check which commit introduced this, and see what the testcase was? It was almost certainly introduced for a case where the increment is large compared to the base time, and none of these tests test this.

@vondele vondele added the needs-analysis Needs further analysis label Mar 3, 2024
@Torom
Copy link
Contributor

Torom commented Mar 3, 2024

If I see this correctly, it was introduced here: #3702

Actually, there was no test with a larger increment than in LTC.

@vondele
Copy link
Member

vondele commented Mar 3, 2024

But probably the special case was : "TCEC Style 10+0.01 "

@FauziAkram
Copy link
Contributor Author

But probably the special case was : "TCEC Style 10+0.01 "

@vondele https://tests.stockfishchess.org/tests/view/65e4ca73416ecd92c162a57d

@FauziAkram
Copy link
Contributor Author

Passed also the TCEC TC style suggested by vondele:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 134150 W: 34278 L: 34163 D: 65709
Ptnml(0-2): 561, 15727, 34444, 15722, 621
https://tests.stockfishchess.org/tests/view/65e4ca73416ecd92c162a57d

@Disservin Disservin added to be merged Will be merged shortly and removed needs-analysis Needs further analysis labels Mar 7, 2024
@Disservin Disservin closed this in a615efb Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants