Do more singular extensions. #4016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if this will be committed I invite to add @alabx to authors list :) |
|
Posting what I mentioned on discord: I have some concerns indeed. This one is now clearly negative in our LTC testing conditions. A revert will pass as an Elo gainer. At that point we end in the situation were we will start to randomly test patches at various conditions, because 'they might scale better'. |
|
I would like to see some work ongoing that refines the SE conditions, we know there is something there that makes this scale as such. If we can identify that, this will be worthwhile in the long run |
|
How bad it is if you avoid double extensions in lower depths? |
|
We don't know, but it is a reasonable idea to test on fishtest. |
|
This conditions were attempted to be refined for a lot of times since first xoto LTC tuning which drastically changed them (it was >= 8). |
vondele
pushed a commit
to vondele/Stockfish
that referenced
this pull request
May 14, 2022
This patch makes the SE depth condition more robust and allows it to scale with completed depth from a previous search. At long TC this patch is almost equivalent to official-stockfish#4016 which had VLTC: https://tests.stockfishchess.org/tests/view/626abd7e8707aa698c0093a8 Elo: 2.35 +-1.5 (95%) LOS: 99.9% Total: 40000 W: 10991 L: 10720 D: 18289 Ptnml(0-2): 8, 3534, 12648, 3799, 11 nElo: 5.47 +-3.4 (95%) PairsRatio: 1.08 VLTC multicore: https://tests.stockfishchess.org/tests/view/6272a6afc8f14123163c1997 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 86808 W: 24165 L: 23814 D: 38829 Ptnml(0-2): 11, 7253, 28524, 7606, 10 however, it is now also gaining at LTC: LTC: https://tests.stockfishchess.org/tests/view/627e7cb523c0c72a05b651a9 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 27064 W: 7285 L: 7046 D: 12733 Ptnml(0-2): 8, 2446, 8390, 2675, 13 and should have nearly no influence at STC as depth 27 is rarely reached. It was noticed that initializing the threshold with MAX_PLY, had an adverse effect, possibly because the first move is sensitive to this. closes official-stockfish#4021 closes official-stockfish#4016 Bench:
vondele
pushed a commit
to vondele/Stockfish
that referenced
this pull request
May 15, 2022
This patch makes the SE depth condition more robust and allows it to scale with completed depth from a previous search. At long TC this patch is almost equivalent to official-stockfish#4016 which had VLTC: https://tests.stockfishchess.org/tests/view/626abd7e8707aa698c0093a8 Elo: 2.35 +-1.5 (95%) LOS: 99.9% Total: 40000 W: 10991 L: 10720 D: 18289 Ptnml(0-2): 8, 3534, 12648, 3799, 11 nElo: 5.47 +-3.4 (95%) PairsRatio: 1.08 VLTC multicore: https://tests.stockfishchess.org/tests/view/6272a6afc8f14123163c1997 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 86808 W: 24165 L: 23814 D: 38829 Ptnml(0-2): 11, 7253, 28524, 7606, 10 however, it is now also gaining at LTC: LTC: https://tests.stockfishchess.org/tests/view/627e7cb523c0c72a05b651a9 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 27064 W: 7285 L: 7046 D: 12733 Ptnml(0-2): 8, 2446, 8390, 2675, 13 and should have nearly no influence at STC as depth 27 is rarely reached. It was noticed that initializing the threshold with MAX_PLY, had an adverse effect, possibly because the first move is sensitive to this. closes official-stockfish#4021 closes official-stockfish#4016 Bench: 6481017
dav1312
pushed a commit
to dav1312/Stockfish
that referenced
this pull request
Oct 21, 2022
This patch makes the SE depth condition more robust and allows it to scale with completed depth from a previous search. At long TC this patch is almost equivalent to official-stockfish#4016 which had VLTC: https://tests.stockfishchess.org/tests/view/626abd7e8707aa698c0093a8 Elo: 2.35 +-1.5 (95%) LOS: 99.9% Total: 40000 W: 10991 L: 10720 D: 18289 Ptnml(0-2): 8, 3534, 12648, 3799, 11 nElo: 5.47 +-3.4 (95%) PairsRatio: 1.08 VLTC multicore: https://tests.stockfishchess.org/tests/view/6272a6afc8f14123163c1997 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 86808 W: 24165 L: 23814 D: 38829 Ptnml(0-2): 11, 7253, 28524, 7606, 10 however, it is now also gaining at LTC: LTC: https://tests.stockfishchess.org/tests/view/627e7cb523c0c72a05b651a9 LLR: 2.94 (-2.94,2.94) <0.50,3.00> Total: 27064 W: 7285 L: 7046 D: 12733 Ptnml(0-2): 8, 2446, 8390, 2675, 13 and should have nearly no influence at STC as depth 27 is rarely reached. It was noticed that initializing the threshold with MAX_PLY, had an adverse effect, possibly because the first move is sensitive to this. closes official-stockfish#4021 closes official-stockfish#4016 Bench: 6481017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch continues work on scaling - last VLTC tuning that was really bad at STC but had shown really good performance at LTC and beyond had the most massive change being lowering singular extensions depth threshold.
This patch does it to even bigger extent - lowers it even more. As a result this patch loses ~8 elo at STC, ~2 elo at LTC but gains elo in both 240+2.4 single thread test and 60+0.6 8 thread test, effectively passing double SPRT (240+2.4 test is fixed games test but it actually passed "STC" SPRT somewhere near 35k games).
So this patch is confirmed with usual fishtest confidence to be an elo gainer on time controls higher than 60+0.6 - which are almost always where stockfish is actually used.
Corresponding tests:
STC:
https://tests.stockfishchess.org/tests/view/626a98a88707aa698c008e7e
Elo: -8.27 +-2.5 (95%) LOS: 0.0%
Total: 20000 W: 5031 L: 5507 D: 9462
Ptnml(0-2): 113, 2522, 5179, 2100, 86
nElo: -15.92 +-4.8 (95%) PairsRatio: 0.83
LTC:
https://tests.stockfishchess.org/tests/view/62694d3309e8b84303aa8df3
LLR: -2.93 (-2.94,2.94) <0.50,3.00>
Total: 22000 W: 5681 L: 5819 D: 10500
Ptnml(0-2): 30, 2335, 6398, 2217, 20
VLTC:
https://tests.stockfishchess.org/tests/view/626abd7e8707aa698c0093a8
Elo: 2.35 +-1.5 (95%) LOS: 99.9%
Total: 40000 W: 10991 L: 10720 D: 18289
Ptnml(0-2): 8, 3534, 12648, 3799, 11
nElo: 5.47 +-3.4 (95%) PairsRatio: 1.08
VLTC multicore:
https://tests.stockfishchess.org/tests/view/6272a6afc8f14123163c1997
LLR: 2.94 (-2.94,2.94) <0.50,3.00>
Total: 86808 W: 24165 L: 23814 D: 38829
Ptnml(0-2): 11, 7253, 28524, 7606, 10
bench 7040579