Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tnnvalmvs1 prcheck #3696

Closed
wants to merge 2 commits into from
Closed

Conversation

xoto10
Copy link
Contributor

@xoto10 xoto10 commented Sep 8, 2021

PR to help check if this code compiles cleanly in all environments.

Bench 6030657

@ppigazzini
Copy link
Contributor

@SFisGOD @xoto10 Stockfish Actions is configured to start automatically for the push of the branch "github_ci" in your repo, see

name: Stockfish
on:
push:
branches:
- master
- tools
- github_ci
pull_request:
branches:
- master
- tools

@xoto10
Copy link
Contributor Author

xoto10 commented Sep 8, 2021

If I need to do anything else, let me know, I don't understand how creating a PR helps anything.

As far as I can see, there was a problem elsewhere with warning: ISO C++ forbids variable length array when a variable was used to dimension an array. I am using a constant, not a variable, so this should not be a problem, and it gives no warnings for me (on linux). I have no indication there is a problem, and reading threads linked here it seems #3671 should stop my test running if there is one. I will assume this code is fine for now unless you guys find something that indicates a problem ...

@SFisGOD
Copy link
Contributor

SFisGOD commented Sep 8, 2021

@xoto10 You may close this now. It seems there is no problem.

@xoto10 xoto10 closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants