Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service to upload an avatar #500

Merged
merged 7 commits into from
Jan 17, 2021
Merged

feat: service to upload an avatar #500

merged 7 commits into from
Jan 17, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jan 16, 2021

This service is the first step towards supporting avatars in OfficeLife.

We'll add other methods in another PR, like resizing avatars etc....

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress - no need here
  • Documentation - no need here yet
  • Dummy data - no need here yet

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

86.3% 86.3% Coverage
13.1% 13.1% Duplication

@djaiss djaiss merged commit a93f79d into main Jan 17, 2021
@djaiss djaiss deleted the 2021-01-14-avatar branch January 17, 2021 01:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 0.1.0-alpha.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant