Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix phpstan issues #331

Merged
merged 14 commits into from
Oct 25, 2020
Merged

fix: fix phpstan issues #331

merged 14 commits into from
Oct 25, 2020

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Oct 25, 2020

Fixing the crapy issues the php langage allow us to write

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

82.6% 82.6% Coverage
0.8% 0.8% Duplication

@asbiin asbiin merged commit 5e28296 into main Oct 25, 2020
@asbiin asbiin deleted the 20201025-phpstan branch October 25, 2020 19:01
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant