Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Props and Methods to index.d.ts #216

Merged
merged 2 commits into from
May 19, 2020
Merged

Add Missing Props and Methods to index.d.ts #216

merged 2 commits into from
May 19, 2020

Conversation

mrjones2014
Copy link
Contributor

index.d.ts was missing one of the props for the component, and missing the uploadFile method from the S3Upload class.

add missing methods and props to index.d.ts
@mrjones2014
Copy link
Contributor Author

@seanadkinson have you looked at this PR yet? it's very small, just a TS definitions change.

@seanadkinson
Copy link
Contributor

@mrjones2014 Thanks, sorry for the delay... will merge

@seanadkinson seanadkinson merged commit ecdb250 into odysseyscience:master May 19, 2020
@mrjones2014
Copy link
Contributor Author

@seanadkinson awesome! thanks! this upgrade will allow me to remove a // @ts-ignore comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants