TypeScript tweaks and fixes #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dobesv
commented
Jan 30, 2020
•
dobesv
commented
- fix: React was used but not imported
- fix: S3Upload extends onFinishS3Put rather than onFinish
- tweak: Add typescript & types/react dev dependencies
- tweak: Explicitly set "types" in package.json
- upload S3Upload options declared to match the ones actually used
dobesv
force-pushed
the
ts-fixup
branch
4 times, most recently
from
ac3ff54
to
b7bedf4
Compare
- fix: React was used but not imported - fix: S3Upload extends onFinishS3Put rather than onFinish - tweak: Add typescript & types/react dev dependencies - tweak: Explicitly set "types" in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.