Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] bottom_bar: ensure active sheet is scrolled into view #5389

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 30, 2024

Description:

Previously, selecting a sheet from the menu did not scroll the bottom bar's sheet list to bring the active sheet into view if it was outside the visible area. This commit resolves the issue by automatically scrolling the sheet list to ensure the active sheet is visible.

Task: 4377840

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5388
Forward-Port-Of: #5345

Previously, selecting a sheet from the menu did not scroll the bottom
bar's sheet list to bring the active sheet into view if it was outside
the visible area. This commit resolves the issue by automatically
scrolling the sheet list to ensure the active sheet is visible.

Task: 4377840
X-original-commit: 2687f53
@robodoo
Copy link
Collaborator

robodoo commented Dec 30, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 30, 2024

This PR targets saas-18.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Dec 30, 2024
Previously, selecting a sheet from the menu did not scroll the bottom
bar's sheet list to bring the active sheet into view if it was outside
the visible area. This commit resolves the issue by automatically
scrolling the sheet list to ensure the active sheet is visible.

closes #5389

Task: 4377840
X-original-commit: 2687f53
Signed-off-by: Dhrutik Patel (dhrp) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Dec 30, 2024
@fw-bot fw-bot deleted the saas-18.1-17.0-fix-scroll-to-active-sheet-dhrp-FYpH-fw branch January 13, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants