Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] cell: keep non-breaking spaces #5365

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 17, 2024

Description

The non-breaking spaces were removed when updating a cell. This caused issues is odoo pivots, since the formula contained a group name with the non-breaking space removed, but the data was still using the non-breaking space.

Task: 4403607

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5364
Forward-Port-Of: #5342

The non-breaking spaces were removed when updating a cell. This caused
issues is odoo pivots, since the formula contained a group name with
the non-breaking space removed, but the data was still using the
non-breaking space.

Task: 4403607
X-original-commit: 5719d7d
@robodoo
Copy link
Collaborator

robodoo commented Dec 17, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 17, 2024

@hokolomopo @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir
Copy link
Collaborator

rrahir commented Dec 17, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 17, 2024
The non-breaking spaces were removed when updating a cell. This caused
issues is odoo pivots, since the formula contained a group name with
the non-breaking space removed, but the data was still using the
non-breaking space.

closes #5365

Task: 4403607
X-original-commit: 5719d7d
Signed-off-by: Adrien Minne (adrm) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo added the 18.1 label Dec 17, 2024
@robodoo robodoo closed this Dec 17, 2024
@fw-bot fw-bot deleted the master-16.0-pivot-non-breaking-space-adrm-iBXZ-fw branch December 31, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants