[FW][FIX] sheet view: DELETE_SHEET in initial revisions #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a revision contains a `UPDATE_CELL`, the sheet is added to the `sheetsWithDirtyViewports` set. But the sheet isn't when deleting the sheet. So if the initial revisions a sheet is updated then deleted, we'll try to update its viewport in the `finalize` and crash. Task: 4405573 X-original-commit: e2c9c48
|
|
|
@hokolomopo @pro-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 17, 2024
If a revision contains a `UPDATE_CELL`, the sheet is added to the `sheetsWithDirtyViewports` set. But the sheet isn't when deleting the sheet. So if the initial revisions a sheet is updated then deleted, we'll try to update its viewport in the `finalize` and crash. closes #5362 Task: 4405573 X-original-commit: e2c9c48 Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
fw-bot
deleted the
master-16.0-delete-sheet-initial-revisions-adrm-PR6r-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a revision contains a
UPDATE_CELL, the sheet is added to thesheetsWithDirtyViewportsset. But the sheet isn't when deleting the sheet. So if the initial revisions a sheet is updated then deleted, we'll try to update its viewport in thefinalizeand crash.Task: 4405573
review checklist
Forward-Port-Of: #5355
Forward-Port-Of: #5343