Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] figure: crash on deleting dragged figure #5332

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] figure: crash on deleting dragged figure #5332

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 9, 2024

Description

There was a traceback if a figure was deleted while being dragged.

Task: 4329240

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5331
Forward-Port-Of: #5223

@hokolomopo
[FIX] figure: crash on deleting dragged figure
20705bd 
There was a traceback if a figure was deleted while being dragged.

Task: 4329240
X-original-commit: fbae6df
@robodoo
Copy link
Collaborator

robodoo commented Dec 9, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 9, 2024

This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Dec 9, 2024
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Dec 10, 2024
@hokolomopo
[FIX] figure: crash on deleting dragged figure
5be7697 
There was a traceback if a figure was deleted while being dragged.

closes #5332

Task: 4329240
X-original-commit: fbae6df
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo closed this Dec 10, 2024
@fw-bot fw-bot deleted the saas-17.4-16.0-figure-dnd-delete-adrm-7yL_-fw branch December 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fw-bot @robodoo @hokolomopo