[FIX] pivot: apply format on measure only a basic formula #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Dec 3, 2024
src/plugins/ui_feature/format.ts
Outdated
Comment on lines
100
to
102
| if (!cell?.isFormula) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
"If the cell is not a formula, the cell is a basic pivot value formula" ?
src/plugins/ui_feature/format.ts
Outdated
| @@ -43,7 +46,7 @@ export class FormatPlugin extends UIPlugin { | |||
| for (let row = zone.top; row <= zone.bottom; row++) { | |||
| const position = { sheetId, col, row }; | |||
| const pivotCell = this.getters.getPivotCellFromPosition(position); | |||
| if (pivotCell.type === "VALUE") { | |||
| if (this.isBasicPivotValueFormula(position, pivotCell)) { | |||
There was a problem hiding this comment.
TBH I would just disable the functionnality on non spreaded pivot formula. It doens't make much sense for splitted formulas to me and sounds very much like black magic that people will not really understand.
I don't expect changing the format on a single =PIVOT.VALUE cell that I put alone on a random sheet to affect the format of the whole pivot on all the other sheet. The point of having splitted pivot is that I can do things on it independantly from the pivot no ?
LucasLefevre
force-pushed
the
18.0-measure-format-basic-lul
branch
3 times, most recently
from
989a17a to
d7b4868
Compare
Let's say I have a computed measure "weighted_delay:sum", on which I applied an integer format. I later use it in a formula such as: =PIVOT.VALUE(1,"weighted_delay:sum","#user_id",A3)/PIVOT.VALUE(1,"__count:sum","#user_id",A3) This is no longer an integer. If I change the format on this formula ☝️, the format is applied on the entire measure, which is not what I want. With this commit, we apply the format on the measure (rather than on the cell) if and only if the value comes from a spilled PIVOT formula. Task: 4377411
LucasLefevre
force-pushed
the
18.0-measure-format-basic-lul
branch
from
d7b4868 to
68eb4c6
Compare
|
@robodoo r+ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Let's say I have a computed measure "weighted delay:sum", on which I applied an integer format.
I later use it in a formula such as:
=PIVOT.VALUE(1,"weighted delay:sum","#user_id",A3)/PIVOT.VALUE(1,"__count:sum","#user_id",A3)
This is no longer an integer. If I change the format on this formula ☝️, the format is applied on the entire measure, which is not what I want.
With this commit, we apply the format on the measure (rather than on the cell)
if and only if the value comes from a spilled PIVOT formula.
Task: 4377411
review checklist