Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] helpers: Add generic helper to sanitize sheet names #5298

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 2, 2024

Some commands or functionalities can dispatch the creation of new sheets. Unfortunately, the sheet names cannot contain specific characters. This revision introduces a generic helper to sanitize the names before using it inside the CREATE_SHEET command.

Task: 4347719

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 4347719

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5297
Forward-Port-Of: #5248

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 2, 2024

@rrahir @LucasLefevre cherrypicking of pull request #5248 failed.

stdout:

Auto-merging src/constants.ts
Auto-merging src/helpers/misc.ts
Auto-merging src/index.ts
CONFLICT (content): Merge conflict in src/index.ts
Auto-merging src/migrations/migration_steps.ts
Auto-merging src/plugins/core/sheet.ts
Auto-merging tests/model/model_import_export.test.ts
Auto-merging tests/sheet/sheets_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Some commands or functionalities can dispatch the creation of new
sheets. Unfortunately, the sheet names cannot contain specific
characters. This revision introduces a generic helper to sanitize
the names before using it inside the CREATE_SHEET command.

Task: 4347719
X-original-commit: e84a864
@rrahir rrahir force-pushed the master-saas-17.4-sanitize-sheet-name-rar-vYMC-fw branch from e0322a3 to bf2116b Compare December 3, 2024 06:50
@rrahir
Copy link
Collaborator

rrahir commented Dec 3, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 3, 2024
Some commands or functionalities can dispatch the creation of new
sheets. Unfortunately, the sheet names cannot contain specific
characters. This revision introduces a generic helper to sanitize
the names before using it inside the CREATE_SHEET command.

closes #5298

Task: 4347719
X-original-commit: e84a864
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo added the 18.1 label Dec 3, 2024
@robodoo robodoo closed this Dec 3, 2024
@fw-bot fw-bot deleted the master-saas-17.4-sanitize-sheet-name-rar-vYMC-fw branch December 17, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants