[FIX] pivot: handle boolean-like function arguments in `getPivotCellF… #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
reviewed
Dec 2, 2024
| @@ -204,11 +206,14 @@ export class PivotUIPlugin extends UIPlugin { | |||
| return EMPTY_PIVOT_CELL; | |||
| } | |||
| if (functionName === "PIVOT") { | |||
| const includeTotal = args[2] === false ? false : undefined; | |||
| const includeColumnHeaders = args[3] === false ? false : undefined; | |||
| const includeTotal = isMatrix(args[2]) ? args[2][0][0] : args[2]; | |||
There was a problem hiding this comment.
Suggested change
| const includeTotal = isMatrix(args[2]) ? args[2][0][0] : args[2]; | |
| const includeTotal = toScalar(args[2]); |
| const includeColumnHeaders = args[3] === false ? false : undefined; | ||
| const includeTotal = isMatrix(args[2]) ? args[2][0][0] : args[2]; | ||
| const shouldIncludeTotal = includeTotal === undefined ? true : toBoolean(includeTotal); | ||
| const includeColumnHeaders = isMatrix(args[3]) ? args[3][0][0] : args[3]; |
There was a problem hiding this comment.
Suggested change
| const includeColumnHeaders = isMatrix(args[3]) ? args[3][0][0] : args[3]; | |
| const includeColumnHeaders = toScalar(args[3]); |
…romPosition` The getter would only detect the 'includeTotal' and 'includeColumnHeaders' arguments if they were explicitely written as boolean and not as boolean-like (i.e; 1,2, 0, -1) values. Task: 4207502
rrahir
force-pushed
the
saas-17.4-fix-pivot-arg-parsing-rar
branch
from
5c49527 to
36b50ff
Compare
robodoo
pushed a commit
that referenced
this pull request
Dec 2, 2024
…romPosition` The getter would only detect the 'includeTotal' and 'includeColumnHeaders' arguments if they were explicitely written as boolean and not as boolean-like (i.e; 1,2, 0, -1) values. closes #5288 Task: 4207502 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…romPosition`
The getter would only detect the 'includeTotal' and 'includeColumnHeaders' arguments if they were explicitely written as boolean and not as boolean-like (i.e; 1,2, 0, -1) values.
Task: 4207502
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4207502
review checklist