Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] conditional_format: improve CF data bar behavior for non-matching range sizes #5266

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 25, 2024

Before this commit, defining a CF data bar rule based on the value of another range requires both ranges to have matching sizes, preventing the CF from being created otherwise. This restriction leads to a poor user experience when copying and pasting CFs, as the CF does not get pasted.

This commit removes the restriction, allowing CF creation in a "best effort" manner when the range sizes do not match. The CF style is therefore applied by comparing the matching cells.

Task: 4280720

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5164

@robodoo
Copy link
Collaborator

robodoo commented Nov 25, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 25, 2024

@Rachico @LucasLefevre cherrypicking of pull request #5164 failed.

stdout:

Auto-merging src/components/translations_terms.ts
Auto-merging src/plugins/core/conditional_format.ts
CONFLICT (content): Merge conflict in src/plugins/core/conditional_format.ts
Auto-merging src/plugins/ui_core_views/evaluation_conditional_format.ts
Auto-merging src/types/commands.ts
Auto-merging tests/conditional_formatting/conditional_formatting_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

…ng range sizes

Before this commit, defining a CF data bar rule based on the value of
another range requires both ranges to have matching sizes, preventing
the CF from being created otherwise. This restriction leads to a poor
user experience when copying and pasting CFs, as the CF does not get
pasted.

This commit removes the restriction, allowing CF creation in a "best effort"
manner when the range sizes do not match. The CF style is therefore applied by
comparing the matching cells.

Task: 4280720
X-original-commit: 64c919e
@rrahir rrahir force-pushed the master-master-improve-cf-bar-rule-mera-_-WL-fw branch from ce9a8cf to 425efee Compare November 28, 2024 07:22
@rrahir
Copy link
Collaborator

rrahir commented Nov 28, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 28, 2024
…ng range sizes

Before this commit, defining a CF data bar rule based on the value of
another range requires both ranges to have matching sizes, preventing
the CF from being created otherwise. This restriction leads to a poor
user experience when copying and pasting CFs, as the CF does not get
pasted.

This commit removes the restriction, allowing CF creation in a "best effort"
manner when the range sizes do not match. The CF style is therefore applied by
comparing the matching cells.

closes #5266

Task: 4280720
X-original-commit: 64c919e
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo added the 18.1 label Nov 28, 2024
@robodoo robodoo closed this Nov 28, 2024
@fw-bot fw-bot deleted the master-master-improve-cf-bar-rule-mera-_-WL-fw branch December 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants