[FIX] composer: overflow on composer at end of screen #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
force-pushed
the
18.0-composer-assistant-overflow-adrm
branch
from
c36aca2 to
e45a369
Compare
The button to close the composer's formula assistant would overflow from the viewport and make an additional scrollbar appear when it's at the end of the screen (eg. standalone composer in the CF color scale panel). This was due to two things: 1) there was a comment with `//`, which is invalid css and disabled the `width` property of the button 2) we were using a `CLOSE_ICON_RADIUS` to compute the position of the formula assistant. But this constant wasn't actually used in the CSS, so the button could have an arbitrary width unrelated to the constant. (in practice it was 18.4px vs 18px, but this would change if we changed the font size). Task: 4315958
hokolomopo
force-pushed
the
18.0-composer-assistant-overflow-adrm
branch
from
e45a369 to
5257103
Compare
|
@robodoo r+ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The button to close the composer's formula assistant would overflow for the viewport and make an additional scrollbar appear when it's at the end of the screen (eg. standalone composer in the CF color scale panel).
This was due to two things:
//, which is invalid css and disabled thewidthproperty of the buttonCLOSE_ICON_RADIUSto compute the position of the formula assistant. But this constant wasn't actually used in the CSS, so the button could have an arbitrary width unrelated to the constant. (in practice it was 18.4px vs 18px, but this would change if we changed the font size).Task: 4315958
review checklist