[FW][FIX] PivotDimension: Prevent DnD on dimension action buttons #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we apply a mouse down on the action buttons of a pivot dimension (e.g. on the trash or hide/show icon) and move of a single pixel, the drag-n-drop of the dimension is triggered, which prevents the default action of the said action button. This commit also prevents this behaviour when targeting the standalone composer of the computed measures. Task: 4095643 X-original-commit: 270308d
|
|
|
@rrahir @LucasLefevre this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 19, 2024
If we apply a mouse down on the action buttons of a pivot dimension (e.g. on the trash or hide/show icon) and move of a single pixel, the drag-n-drop of the dimension is triggered, which prevents the default action of the said action button. This commit also prevents this behaviour when targeting the standalone composer of the computed measures. closes #5227 Task: 4095643 X-original-commit: 270308d Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
fw-bot
deleted the
master-18.0-prevent-dnd-on-dimension-action-button-rar-_G0K-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we apply a mouse down on the action buttons of a pivot dimension (e.g. on the trash or hide/show icon) and move of a single pixel, the drag-n-drop of the dimension is triggered, which prevents the default action of the said action button.
This commit also prevents this behaviour when targeting the standalone composer of the computed measures.
Task: 4095643
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #5183