[FIX] chart: trend line legend is wrong #5226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hokolomopo @LucasLefevre unable to stage: merge conflict |
The trend line legend is a circle instead of a line in scatter charts. And it's a rectangle in bar chart. Also the onClick of the legend was slightly wrong: we used the index of the legend item to check which dataset to hide. Which didn't work if for whatever reason ChartJs decided to change the order of the legend items. task: 4342471
LucasLefevre
force-pushed
the
master-trend-legend-adrm
branch
from
13dccee to
9f752f2
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 3, 2024
The trend line legend is a circle instead of a line in scatter charts. And it's a rectangle in bar chart. Also the onClick of the legend was slightly wrong: we used the index of the legend item to check which dataset to hide. Which didn't work if for whatever reason ChartJs decided to change the order of the legend items. closes #5226 Task: 4342471 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The trend line legend is a circle instead of a line in scatter charts. And it's a rectangle in bar chart.
Also the onClick of the legend was slightly wrong: we used the index of the legend item to check which dataset to hide. Which didn't work if for whatever reason ChartJs decided to change the order of the legend items.
Task: 4342471
review checklist