[FW][FIX] xlsx: convert #REF at export to xlsx #5151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on how we get a formula with #REF, the parser can have different behavior even if the formula is the same. - If we write directly =#REF (or it comes from a snapshot), the parser will throw an error. - If we write =A1, then delete the row 1 to get =#REF, the parser will return a REFERENCE token with an #REF value. This is a bit of a problem when exporting the data to xlsx: since we parse the formulas to know whether we need to export it, we get a different result depending on how we got the #REF. Task: 4207052 X-original-commit: f20d87a
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @LucasLefevre ci/runbot failed on this forward-port PR |
Reference errors in excel are #REF!, not #REF. Task: 4207052 X-original-commit: 0084194
hokolomopo
force-pushed
the
saas-17.4-16.0-ref-error-xlsx-export-adrm-qc4b-fw
branch
from
72debc4 to
1fff843
Compare
|
@hokolomopo @LucasLefevre this PR was modified / updated and has become a normal PR. It must be merged directly. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 29, 2024
Depending on how we get a formula with #REF, the parser can have different behavior even if the formula is the same. - If we write directly =#REF (or it comes from a snapshot), the parser will throw an error. - If we write =A1, then delete the row 1 to get =#REF, the parser will return a REFERENCE token with an #REF value. This is a bit of a problem when exporting the data to xlsx: since we parse the formulas to know whether we need to export it, we get a different result depending on how we got the #REF. Task: 4207052 X-original-commit: f20d87a Part-of: #5151 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 29, 2024
Reference errors in excel are #REF!, not #REF. closes #5151 Task: 4207052 X-original-commit: 0084194 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] xlsx: convert #REF at export to xlsx:
Reference errors in excel are #REF!, not #REF.
[FIX] parser: inconsistent handling of #REF
Depending on how we get a formula with #REF, the parser can have
different behavior even if the formula is the same.
will throw an error.
return a REFERENCE token with an #REF value.
This is a bit of a problem when exporting the data to xlsx: since
we parse the formulas to know whether we need to export it, we get
a different result depending on how we got the #REF.
Task: 4207052
review checklist
Forward-Port-Of: #5150
Forward-Port-Of: #5019