[FW][FIX] xlsx: convert #REF at export to xlsx #5148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hokolomopo @LucasLefevre cherrypicking of pull request #5019 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Depending on how we get a formula with #REF, the parser can have different behavior even if the formula is the same. - If we write directly =#REF (or it comes from a snapshot), the parser will throw an error. - If we write =A1, then delete the row 1 to get =#REF, the parser will return a REFERENCE token with an #REF value. This is a bit of a problem when exporting the data to xlsx: since we parse the formulas to know whether we need to export it, we get a different result depending on how we got the #REF. Task: 4207052
Reference errors in excel are #REF!, not #REF. Task: 4207052
hokolomopo
force-pushed
the
17.0-16.0-ref-error-xlsx-export-adrm-xNJ5-fw
branch
from
78b7289 to
6c3bd21
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 28, 2024
Depending on how we get a formula with #REF, the parser can have different behavior even if the formula is the same. - If we write directly =#REF (or it comes from a snapshot), the parser will throw an error. - If we write =A1, then delete the row 1 to get =#REF, the parser will return a REFERENCE token with an #REF value. This is a bit of a problem when exporting the data to xlsx: since we parse the formulas to know whether we need to export it, we get a different result depending on how we got the #REF. Task: 4207052 Part-of: #5148 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 28, 2024
Reference errors in excel are #REF!, not #REF. closes #5148 Task: 4207052 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] xlsx: convert #REF at export to xlsx:
Reference errors in excel are #REF!, not #REF.
[FIX] parser: inconsistent handling of #REF
Depending on how we get a formula with #REF, the parser can have
different behavior even if the formula is the same.
will throw an error.
return a REFERENCE token with an #REF value.
This is a bit of a problem when exporting the data to xlsx: since
we parse the formulas to know whether we need to export it, we get
a different result depending on how we got the #REF.
Task: 4207052
review checklist
Forward-Port-Of: #5019